Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unnecessary logical conditions #579

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tobemonkey
Copy link

@tobemonkey tobemonkey commented Sep 14, 2024

Alright, I know this small change might seem insignificant, but after thinking it over, I’ve decided to submit my code and hope it gets accepted


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/579/head:pull/579
$ git checkout pull/579

Update a local copy of the PR:
$ git checkout pull/579
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/579/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 579

View PR using the GUI difftool:
$ git pr show -t 579

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/579.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Sep 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2024

Hi @tobemonkey, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user tobemonkey" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk
Copy link

openjdk bot commented Sep 14, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 14, 2024

⚠️ @tobemonkey a branch with the same name as the source branch for this pull request (master) is present in the target repository. If you eventually integrate this pull request then the branch master in your personal fork will diverge once you sync your personal fork with the upstream repository.

To avoid this situation, create a new branch for your changes and reset the master branch. You can do this by running the following commands in a local repository for your personal fork. Note: you do not have to name the new branch NEW-BRANCH-NAME.

$ git checkout -b NEW-BRANCH-NAME
$ git branch -f master b7348860e89a8aa4466caf7eea1fe628f5b8942a
$ git push -f origin master

Then proceed to create a new pull request with NEW-BRANCH-NAME as the source branch and close this one.

@tobemonkey
Copy link
Author

/signed

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Sep 14, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2024

Thank you! Please allow for up to two weeks to process your OCA, although it is usually done within one to two business days. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@robilad
Copy link

robilad commented Sep 18, 2024

Hi, please send me an e-mail at [email protected] so that I can verify your account.

@zzambers
Copy link
Contributor

zzambers commented Oct 3, 2024

@tobemonkey I cannot comment on the change itself, but this condition does not seem specific to 8 and is also present in newest jdk. Changes should generally go to newest jdk (unless it is something specific to old jdk). Then it can backported (gradually from newest to oldest), if desired.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status
Development

Successfully merging this pull request may close these issues.

3 participants