Update building.md

[douglasawh]

VS2010 no longer works properly. VS2019 is tested to work

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Error

 ⚠️ OCA signatory status must be verified

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk8u-dev.git pull/582/head:pull/582
$ git checkout pull/582

Update a local copy of the PR:
$ git checkout pull/582
$ git pull https://git.openjdk.org/jdk8u-dev.git pull/582/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 582

View PR using the GUI difftool:
$ git pr show -t 582

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk8u-dev/pull/582.diff

[bridgekeeper]

Hi @douglasawh, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user douglasawh" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[zzambers]

Build using VS2010 should work, it is being tested in GHA. There was a temporary problem recently, but that was fixed by JDK-8337312.

[gnu-andrew]

Yes, VS2010 is regularly tested by GHA. Unfortunately, it can occasionally be broken by security fixes which can not go through GHA due to embargo.

I don't think it's appropriate to change build requirements at this stage in the 8u lifecycle, especially to a version so much later.

[gnu-andrew]

Incidentally, for future patch submissions, you should enable GitHub actions on your fork.