Enable Goole WIF Support for Tecton-Caches #71
Conversation
SRVKP-6522 - Enable Google WIF Support SRVKP-6522 - Fix Lint
| projected: | ||
| sources: | ||
| - serviceAccountToken: | ||
| audience: https://iam.googleapis.com/projects/272779626560/locations/global/workloadIdentityPools/openshift-pool/providers/opeshift-wif |
There was a problem hiding this comment.
Can you please put this in conventional format for k8s and OpenShift?
There was a problem hiding this comment.
Some of our customers will complain that WIF isn't properly supported if do this. We already have a mail on this for OpenShift Logging.
There was a problem hiding this comment.
They way it was setup audience is getting generated like this only. Will check if this can be simplified
There was a problem hiding this comment.
Yes, that and location where we project should also be similar.
| @@ -0,0 +1,62 @@ | |||
| #!/usr/bin/env bash | |||
| set -x | |||
There was a problem hiding this comment.
I think we should have this script in e2e section.
There was a problem hiding this comment.
For now we dont have have e2e for GCS and AWS as that will require test accounts configuration in Github action. once that is done we can move it to e2e.
| @@ -0,0 +1,34 @@ | |||
| --- | |||
There was a problem hiding this comment.
This file should ideally be in example folder.
| @@ -70,12 +70,12 @@ spec: | |||
| value: $(params.googleCredentialsPath) | |||
There was a problem hiding this comment.
This file should be in the config folder. That's how we do it for every other Tekton project.
There was a problem hiding this comment.
We now have step actions in two folder - tekton and this.
Should be merged to config.
No description provided.