Patch the CSV to handle breaking change for peer-pods #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkurz
reviewed
Sep 4, 2024
| @@ -88,6 +88,14 @@ spec: | |||
| value: registry.redhat.io/openshift-sandboxed-containers/osc-podvm-builder-rhel9:1.7.0 | |||
| - name: RELATED_IMAGE_PODVM_PAYLOAD | |||
| value: registry.redhat.io/openshift-sandboxed-containers/osc-podvm-payload-rhel9:1.7.0 | |||
| - name: RELEASE_VERSION | |||
| value: 1.7.0 | |||
There was a problem hiding this comment.
This could be inferred out of the version tag of one of the related images but I guess having an explicit env results in simpler code in the operator.
The latest CAA code shipped with 1.7.0 introduces breaking change and requires cluster to be at latest 4.15 z stream. To avoid breaking users on older versions, this code will patch the CSV to refer to 1.6.0 CAA images Signed-off-by: Pradipta Banerjee <[email protected]>
This includes base CSV file changes, RBAC changes etc. These changes need to be manually incorporated in downstream builds Signed-off-by: Pradipta Banerjee <[email protected]>
Inclusion of https://github.com/operator-framework/api/ v0.22.0 for patching the operator CSV updates the controller-runtime deps which requires to adapt the code. v0.22.0 is the min version supporting golang 1.21 that is used to build the 1.7.0 operator code. Signed-off-by: Pradipta Banerjee <[email protected]>
bpradipt
force-pushed
the
1.7-csv-patch
branch
from
4483ae1
to
b0159d2
Compare
bpradipt
added
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.