Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework MRI test exclusions #3658

Merged
merged 27 commits into from
Sep 27, 2024
Merged

Rework MRI test exclusions #3658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
4861136
Improve the context message for auto-generated MRI test exclusion flags.
nirvdrum Mar 11, 2023
7f4a6c9
Move the ',' delimiter into the prefix because otherwise partial name…
nirvdrum Mar 11, 2023
626100e
Sort the MRI tag files so we get deterministic output.
nirvdrum Mar 11, 2023
bffd383
Allow `jt retag` to skip over MRI tests that were previously known to…
nirvdrum Mar 11, 2023
56f38f1
Fix search of MRI test exclusion files.
nirvdrum Sep 16, 2024
396cbc2
Deeper parsing of MRI test failures to extract a useful reason messag…
nirvdrum Sep 16, 2024
7106f57
More `jt retag` retentions.
nirvdrum Mar 16, 2023
f39954d
Handle invalid byte sequences in the MRI test errors.
nirvdrum Sep 4, 2024
7bef864
Handle extracting class names from MRI test files that aren't UTF-8.
nirvdrum Sep 4, 2024
7e619c1
Improve MRI test exclusion messages when the correct exception type i…
nirvdrum Sep 4, 2024
630b9f3
Add automatic tagging of slow tests to MRI test tagging.
nirvdrum Sep 4, 2024
5e83488
Make MRI test retagging more resilient to escaped exceptions.
nirvdrum Sep 4, 2024
a36adb7
More accurately extract test failure reason when retagging MRI tests.
nirvdrum Sep 5, 2024
c9ac0cc
Add a retry loop when tagging MRI test files that fail due to undefin…
nirvdrum Sep 7, 2024
bbfa38f
Add a retry loop when tagging MRI test files that fail due to a JVM c…
nirvdrum Sep 7, 2024
53e0cd7
Retain MRI test exclusion tags for tests that have historically been …
nirvdrum Sep 8, 2024
c40909b
Handle tag generation for MRI tests that time out.
nirvdrum Sep 9, 2024
e9df4ce
Handle dyld symbol load errors on macOS when tagging MRI tests.
nirvdrum Sep 9, 2024
e1a60ef
Handle MRI tests that exit with a non-zero status code when retagging.
nirvdrum Sep 9, 2024
039be93
Automatically add platform-specific tags for MRI tests that are platf…
nirvdrum Sep 11, 2024
f26bec6
Improve the sorting of MRI test tags.
nirvdrum Sep 11, 2024
01fe314
Restructure the MRI test log parser to make the various regexps easie…
nirvdrum Sep 11, 2024
511dc7e
Added more documentation for each of the regexps used in parsing the …
nirvdrum Sep 11, 2024
8374832
Add built macOS dynamic libraries to the git ignore list.
nirvdrum Sep 11, 2024
69c296a
Regenerate the list of MRI test exclusions.
nirvdrum Sep 4, 2024
48e835c
Remove some patterns for retaining MRI test exclusions upon retag.
nirvdrum Sep 17, 2024
6d05853
Ensure the patterns to retain MRI test exclusions are not matched aga…
nirvdrum Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ src/main/c/**/*.o
src/main/c/**/*.so
src/main/c/**/*.a
src/main/c/**/*.bundle
src/main/c/**/*.dylib
src/main/c/**/extconf.h
src/main/c/**/mkmf.log
src/main/c/*/Makefile
Expand Down
2 changes: 1 addition & 1 deletion test/mri/excludes/Bug/Struct/Test_Member.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
exclude :test_member_get, "needs investigation"
exclude :test_member_get, "Expected Exception(NameError) was raised, but the message doesn't match. Expected /is not a struct member/ to match \"no member 'b' in struct\"."
2 changes: 1 addition & 1 deletion test/mri/excludes/Bug/Time/Test_New.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
exclude :test_timespec_new, "needs investigation"
exclude :test_timespec_new, "ArgumentError: Zone offset not in valid range: -18:00 to +18:00"
2 changes: 0 additions & 2 deletions test/mri/excludes/CGIUtilPureRubyTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,2 @@
exclude :test_cgi_escapeHTML_with_invalid_byte_sequence, "NameError: uninitialized constant CGI::Escape"
exclude :test_cgi_escapeHTML_with_invalid_byte_sequence, "needs investigation"
exclude :test_cgi_unescapeHTML_with_invalid_byte_sequence, "NameError: uninitialized constant CGI::Escape"
exclude :test_cgi_unescapeHTML_with_invalid_byte_sequence, "needs investigation"
33 changes: 16 additions & 17 deletions test/mri/excludes/Complex_Test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,17 @@
exclude :test_Complex_with_invalid_exception, "needs investigation"
exclude :test_Complex_without_exception, "needs investigation"
exclude :test_add_with_redefining_int_plus, "needs investigation"
exclude :test_compsub, "needs investigation"
exclude :test_conv, "needs investigation"
exclude :test_div, "needs investigation"
exclude :test_expt, "needs investigation"
exclude :test_fixed_bug, "needs investigation"
exclude :test_infinite_p, "needs investigation"
exclude :test_marshal_compatibility, "needs investigation"
exclude :test_mul, "needs investigation"
exclude :test_parse, "needs investigation"
exclude :test_ruby19, "needs investigation"
exclude :test_sub_with_redefining_int_minus, "needs investigation"
exclude :test_canonicalize_internal, "needs investigation"
exclude :test_rationalize, "needs investigation"
exclude :test_polar, "needs investigation"
exclude :test_Complex_with_invalid_exception, "ArgumentError expected but nothing was raised."
exclude :test_Complex_without_exception, "RuntimeError: "
exclude :test_add_with_redefining_int_plus, "| <internal:core> core/truffle/ffi/pointer.rb:145:in `check_bounds': Memory access offset=0 size=5 is out of bounds (IndexError)"
exclude :test_canonicalize_internal, "NoMethodError: undefined method `+' for #<#<Class:0x538>:0x558 @real=false>"
exclude :test_coerce2, "<=>."
exclude :test_compsub, "Expected (1+0i) to be an instance of ComplexSub, not Complex."
exclude :test_conv, "Expected (1+0i) (oid=1624) to be the same as (1+0i) (oid=1640)."
exclude :test_div, "Expected (1/1) to be integer?."
exclude :test_expt, "<(-3+4i)> expected but was <(-3.0+4.000000000000002i)>."
exclude :test_fixed_bug, "ArgumentError expected but nothing was raised."
exclude :test_infinite_p, "Expected 1 to be nil."
exclude :test_marshal_compatibility, "Exception raised: <#<NoMethodError: undefined method `<' for nil:NilClass>>"
exclude :test_mul, "<(Infinity+0i)> expected but was <(Infinity+NaN*i)>."
exclude :test_polar, "TypeError: not a real"
exclude :test_rationalize, "NoMethodError: undefined method `abs' for nil:NilClass"
exclude :test_ruby19, "NoMethodError expected but nothing was raised."
exclude :test_sub_with_redefining_int_minus, "| <internal:core> core/truffle/ffi/pointer.rb:145:in `check_bounds': Memory access offset=0 size=42 is out of bounds (IndexError)"
1 change: 1 addition & 0 deletions test/mri/excludes/DRbTests/TestBug16634.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :test_bug16634, "ArgumentError: wrong number of arguments (given 1, expected 0)"
3 changes: 3 additions & 0 deletions test/mri/excludes/DRbTests/TestDRbCore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
exclude :test_02_unknown, "<\"DRbTests::DRbEx::\"> expected but was <\"DRbTests::DRbEx::FooBar\">."
exclude :test_06_timeout, "[Timeout::Error] exception expected, not #<DRb::DRbConnError: execution expired>."
exclude :test_11_remote_no_method_error, "[DRb::DRbRemoteError] exception expected, not #<NoMethodError: undefined method `invoke_no_method' for #<DRbTests::DRbEx:0x4d8>>."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering why these failing tests aren't already excluded (as well as TestBundlerGem.rb, TestBignum_Pack.rb, TestNetHTTPForceEncoding.rb etc). Does it mean they are not run on CI at all?
cc @eregon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That one at least it's from test/mri/failing.exclude which excludes test/mri/tests/drb/test_drb.rb entirely.

Maybe we should remove the drb tests from there then if they work?
One concern about DRb is DRb uses ObjectSpace._id2ref which can be really slow, so tests doing that should probably be tagged as slow/very slow, which might happen automatically.

Copy link
Member

@eregon eregon Sep 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about TestBundlerGem I don't see anything excluding that. You could check in CI logs to see if that gets run in CI currently. If yes, then maybe there are extra failures when run by @nirvdrum compared to CI for some reason?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a for loop in my shell over each of the MRI test files and ran jt retag on them. It looks like we originally tagged these files differently. I think it's quite convenient being able to retag everything in a shell loop, so I'd like to keep the new tags. I didn't know about test/mri/failing.exclude.

I can either delete the entries there and keep the individual tags or I can update jt retag to compare the current test file against whatever's in failing.exclude. I think I'm slightly partial to the former since that would give us reasons for each exclusion. But, if we just don't support a particular feature, I could see a bulk block making sense.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised jt test mri FILE when FILE is in failing.exclude would even run given on master it doesn't in that case:

$ jt test mri test/mri/tests/drb/test_drb.rb
Using Interpreted TruffleRuby: mxbuild/truffleruby-jvm
No test files! (probably filtered out by failing.exclude)

But I guess with this PR changes it behaves/behaved differently.

Anyway, if these can run it seems fine to remove them from failing.exclude, unless marked as too slow.
It's also OK to do nothing about these and just merge as it is, as it might be a rabbit hole to remove from this failing list.

1 change: 1 addition & 0 deletions test/mri/excludes/DRbTests/TestDRbLarge.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :test_03_large_ary, "TypeError: allocator undefined for Thread"
4 changes: 4 additions & 0 deletions test/mri/excludes/DRbTests/TestDRbReusePort.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,6 @@
exclude :test_01, "NoMethodError: undefined method `manager' for nil:NilClass"
exclude :test_02_collect, "NoMethodError: undefined method `manager' for nil:NilClass"
exclude :test_03_redo, "NoMethodError: undefined method `manager' for nil:NilClass"
exclude :test_05_break, "needs investigation"
exclude :test_06_next, "NoMethodError: undefined method `manager' for nil:NilClass"
exclude :test_07_break_18, "needs investigation"
2 changes: 2 additions & 0 deletions test/mri/excludes/DRbTests/TestDRbSSLCore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
exclude :test_06_timeout, "[Timeout::Error] exception expected, not #<DRb::DRbConnError: execution expired>."
exclude :test_11_remote_no_method_error, "[DRb::DRbRemoteError] exception expected, not #<NoMethodError: undefined method `invoke_no_method' for #<DRbTests::DRbEx:0xdf8>>."
2 changes: 2 additions & 0 deletions test/mri/excludes/DRbTests/TestDRbSafe1.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
exclude :test_05_break, "DRb::DRbConnError: connection closed"
exclude :test_07_break_18, "DRb::DRbConnError: connection closed"
2 changes: 2 additions & 0 deletions test/mri/excludes/DRbTests/TestDRbUNIXCore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
exclude :test_06_timeout, "[Timeout::Error] exception expected, not #<DRb::DRbConnError: execution expired>."
exclude :test_11_remote_no_method_error, "[DRb::DRbRemoteError] exception expected, not #<NoMethodError: undefined method `invoke_no_method' for #<DRbTests::DRbEx:0x688>>."
83 changes: 14 additions & 69 deletions test/mri/excludes/ErrorHighlightTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,70 +1,15 @@
exclude :test_args_ATTRASGN_1, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_ATTRASGN_2, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_ATTRASGN_3, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_CALL_1, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_CALL_2, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_FCALL_1, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_FCALL_2, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_OPCALL, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_OP_ASGN1_aref_1, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_OP_ASGN1_aref_2, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_OP_ASGN1_op, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_args_OP_ASGN2, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_custom_formatter, "NameError: uninitialized constant ErrorHighlight::Ractor"
exclude :test_OP_ASGN1_op_4, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_ATTRASGN_2, "<\"undefined method `[]=' for nil:NilClass\\n\" +"
exclude :test_OPCALL_binary_2, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_ATTRASGN_4, "<\"undefined method `[]=' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN1_op_2, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_OPCALL_unary_2, "<\"undefined method `+@' for nil:NilClass\\n\" +"
exclude :test_CALL_arg_5, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN1_aref_1, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_CALL_arg_1, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_COLON2_2, "<\"uninitialized constant ErrorHighlightTest::NotDefined\\n\" +"
exclude :test_OP_ASGN2_op_2, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_CALL_arg_3, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_const_get, "<\"uninitialized constant ErrorHighlightTest::NotDefined\\n\" +"
exclude :test_OP_ASGN2_read_3, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN2_read_1, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_noarg_2, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OP_CDECL_toplevel_2, "<\"undefined method `+' for ErrorHighlightTest:Class\\n\" +"
exclude :test_CALL_noarg_4, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_send, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_aref_1, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_CALL_aref_5, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_CALL_aset, "<\"undefined method `[]=' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN2_write_2, "<\"undefined method `foo=' for #<Object:0x1d6a1b8>\\n\" +"
exclude :test_OP_ASGN1_aset_1, "<\"undefined method `[]=' for #<Object:0x1d6a268>\\n\" +"
exclude :test_OP_ASGN1_aset_3, "<\"undefined method `[]=' for #<Object:0x1d6a318>\"> expected but was"
exclude :test_QCALL_2, "<\"undefined method `foo' for 1:Integer\\n\" +"
exclude :test_FCALL_2, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_COLON3, "<\"uninitialized constant NotDefined\\n\" +"
exclude :test_OP_CDECL_op_1, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_OP_CDECL_read_1, "<\"uninitialized constant ErrorHighlightTest::OP_CDECL_TEST::NotDefined\\n\" +"
exclude :test_OP_CDECL_op_3, "NoMethodError expected but nothing was raised."
exclude :test_local_variable_get, "<\"local variable `foo' is not defined for #<Binding:0x1d6a628>\\n\" +"
exclude :test_OP_ASGN1_aset_2, "<\"undefined method `[]=' for #<Object:0x1d6a6a8>\\n\" +"
exclude :test_QCALL_1, "<\"undefined method `foo' for 1:Integer\\n\" +"
exclude :test_OP_ASGN2_write_1, "<\"undefined method `foo=' for #<Object:0x1d6a7f8>\\n\" +"
exclude :test_OP_ASGN2_write_3, "<\"undefined method `foo=' for #<Object:0x1d6a8a8>\\n\" +"
exclude :test_OP_ASGN1_aset_4, "<\"undefined method `[]=' for #<Object:0x1d6a958>\\n\" +"
exclude :test_OP_CDECL_read_2, "<\"uninitialized constant ErrorHighlightTest::OP_CDECL_TEST::NotDefined\\n\" +"
exclude :test_OP_CDECL_op_2, "NoMethodError expected but nothing was raised."
exclude :test_VCALL_2, "<\"undefined local variable or method `foo' for nil:NilClass\\n\" +"
exclude :test_FCALL_1, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_op_asgn, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_OP_CDECL_toplevel_1, "<\"uninitialized constant NotDefined\\n\" +"
exclude :test_CALL_noarg_1, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_noarg_3, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_CALL_aref_4, "<\"undefined method `[]' for #<Object:0x1d6ad58>\\n\" +"
exclude :test_CALL_aref_2, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_explicit_raise_no_method_error, "<\"NoMethodError\\n\" + \"\\n\" + \" raise NoMethodError\\n\" + \" ^^^^^\"> expected but was"
exclude :test_explicit_raise_name_error, "<\"NameError\\n\" + \"\\n\" + \" raise NameError\\n\" + \" ^^^^^\"> expected but was"
exclude :test_OP_ASGN2_read_2, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN1_op_1, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_ATTRASGN_5, "<\"undefined method `foo=' for nil:NilClass\\n\" +"
exclude :test_OPCALL_binary_3, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_ATTRASGN_3, "<\"undefined method `foo=' for nil:NilClass\\n\" +"
exclude :test_OPCALL_binary_1, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_ATTRASGN_1, "<\"undefined method `[]=' for nil:NilClass\\n\" +"
exclude :test_CALL_arg_2, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN2_op_3, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_CONST, "<\"uninitialized constant ErrorHighlightTest::NotDefined\\n\" +"
exclude :test_OP_ASGN1_aref_4, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_OP_ASGN2_op_1, "<\"undefined method `+' for nil:NilClass\\n\" +"
exclude :test_COLON2_1, "[NameError] exception expected, not #<TypeError: 1:Integer is not a class/module>."
exclude :test_CALL_arg_6, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_OPCALL_unary_1, "<\"undefined method `+@' for nil:NilClass\\n\" + \"\\n\" + \" + nil\\n\" + \" ^\"> expected but was"
exclude :test_hard_tabs, "<\"undefined method `time' for 1:Integer\\n\" +"
exclude :test_CALL_arg_4, "<\"undefined method `foo' for nil:NilClass\\n\" +"
exclude :test_no_final_newline, "<\"undefined method `time' for 1:Integer\\n\" + \"\\n\" + \"1.time {}\\n\" + \" ^^^^^\"> expected but was"
exclude :test_OP_ASGN1_aref_2, "<\"undefined method `[]' for nil:NilClass\\n\" +"
exclude :test_OP_CDECL_read_3, "<\"uninitialized constant ErrorHighlightTest::OP_CDECL_TEST::NotDefined\"> expected but was"
exclude :test_spot_with_backtrace_location, "NameError: uninitialized constant ErrorHighlight::RubyVM"
exclude :test_spot_with_node, "NameError: uninitialized constant ErrorHighlightTest::RubyVM"
1 change: 1 addition & 0 deletions test/mri/excludes/JSONCommonInterfaceTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :test_dump, "SystemStackError: stack level too deep"
1 change: 1 addition & 0 deletions test/mri/excludes/JSONParserTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
exclude :test_nesting, "[JSON::NestingError] exception expected, not #<SystemStackError: stack level too deep"
4 changes: 2 additions & 2 deletions test/mri/excludes/MethodNameCheckTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
exclude :test_corrections_when_private_method_is_called_with_args, "needs investigation"
exclude :test_suggests_yield, "needs investigation"
exclude :test_corrections_when_private_method_is_called_with_args, "Expected [] to only include :raise."
exclude :test_suggests_yield, "Expected [] to only include :yield."
2 changes: 1 addition & 1 deletion test/mri/excludes/NameErrorExtensionTest.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
exclude :test_correctable_error_objects_are_dumpable, "needs investigation"
exclude :test_correctable_error_objects_are_dumpable, "<\"undefined method `sizee' for #<File:test_name_error_extension.rb (closed)>\"> expected but was <\"undefined method `sizee' for #<File:0x3c8 path=test_name_error_extension.rb (closed)>\">."
2 changes: 0 additions & 2 deletions test/mri/excludes/Psych_Unit_Tests.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +0,0 @@
exclude :test_ruby_complex, "needs investigation"
exclude :test_ruby_rational, "needs investigation"
22 changes: 10 additions & 12 deletions test/mri/excludes/Rational_Test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
exclude :test_Rational_with_invalid_exception, "needs investigation"
exclude :test_fixed_bug, "needs investigation"
exclude :test_marshal, "needs investigation"
exclude :test_marshal_compatibility, "needs investigation"
exclude :test_parse, "needs investigation"
exclude :test_power_of_0, "needs investigation"
exclude :test_supp, "needs investigation"
exclude :test_to_f, "needs investigation"
exclude :test_Rational_without_exception, "needs investigation"
exclude :test_conv, "needs investigation"
exclude :test_power_overflow, "needs investigation"
exclude :test_ratsub, "needs investigation"
exclude :test_Rational_with_invalid_exception, "[ArgumentError] exception expected, not #<TypeError: denominator is not an Integer>."
exclude :test_Rational_without_exception, "TypeError: denominator is not an Integer"
exclude :test_conv, "RangeError: can't' convert 1+2i into Rational"
exclude :test_marshal, "TypeError expected but nothing was raised."
exclude :test_marshal_compatibility, "TypeError expected but nothing was raised."
exclude :test_parse, "Rational(\"5__5/33\")."
exclude :test_power_of_0, "Expected 0.0 to be an instance of Rational, not Float."
exclude :test_power_overflow, "FloatDomainError: Infinity"
exclude :test_ratsub, "ArgumentError: wrong number of arguments (given 1, expected 2)"
exclude :test_supp, "<3.330669073875469e-16> expected but was <3.3306690738754696e-16>."
1 change: 0 additions & 1 deletion test/mri/excludes/Reline/Test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
exclude :test_dumb_terminal, "<\"Reline::GeneralIO\"> expected but was"
20 changes: 10 additions & 10 deletions test/mri/excludes/TestAddressResolve.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
exclude :test_addrinfo_tcp_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_pf_unspec_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_socket_getnameinfo_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_no_host_non_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_ipv6_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_ipv4_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_any_non_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_ip_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_full_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_udp_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_non_existing_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_ipv4_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_ipv6_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_localhost, "hangs, no Fiber.set_scheduler"
exclude :test_ip_socket_getaddress_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_no_host_non_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_non_existing_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_numeric_non_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_getaddrinfo_pf_unspec_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_ip_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_tcp_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_addrinfo_udp_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_ip_socket_getaddress_domain_blocking, "hangs, no Fiber.set_scheduler"
exclude :test_socket_getnameinfo_domain_blocking, "hangs, no Fiber.set_scheduler"
4 changes: 1 addition & 3 deletions test/mri/excludes/TestAlias.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1 @@
exclude :test_alias_class_method_added, "needs investigation"
exclude :test_alias_module_method_added, "needs investigation"
exclude :test_alias_inspect, "needs investigation"
exclude :test_alias_inspect, "<\"TestAlias::Alias4(TestAlias::Alias0)#foo1(foo)()\"> expected but was <\"TestAlias::Alias4#foo1()\">."
Loading
Loading