Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get python project name and version from files. #405

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

xbarra
Copy link
Contributor

@xbarra xbarra commented Sep 30, 2024

Use pyproject.toml if present, otherwise setup.py.

Co-authored-by: Arfima Dev [email protected]
Signed-off-by: Xavier Barrachina Civera [email protected]

Use pyproject.toml if present, otherwise setup.py.

Signed-off-by: Xavier Barrachina Civera <[email protected]>
@xbarra xbarra marked this pull request as draft September 30, 2024 11:22
@xbarra xbarra marked this pull request as ready for review September 30, 2024 11:38
@xbarra
Copy link
Contributor Author

xbarra commented Sep 30, 2024

Problem is that it won't actually use the actions we are changing until they are in main, so the result of the workflow is not that useful.

Note that both project version an project name actions are so similar that could be parametrized.

We are using pdm (and setuptools if there instead of a pyproject.toml there is a setup.py) to extract the information.
pdm works even if the pyproject.toml has another build system.
In our tests we went to the folder setup.py is in, since modern versions of setuptools read first pyproject.toml.

@ModeSevenIndustrialSolutions ModeSevenIndustrialSolutions merged commit 7ebadce into os-climate:main Sep 30, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants