-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat(node:http2) Implement HTTP2 server support #14286
Draft
cirospaciari
wants to merge
76
commits into
main
Choose a base branch
from
ciro/http2-server
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+5,536
−1,918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cirospaciari
force-pushed
the
ciro/http2-server
branch
2 times, most recently
from
October 6, 2024 20:01
459bd3c
to
7e4dbbb
Compare
cirospaciari
force-pushed
the
ciro/http2-server
branch
from
October 7, 2024 18:59
adc42c9
to
8dcea5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Major Client compatibility fixes + Server implementation
Fix: #8823
Fix: #14249
Notes
Push (not supported in most browsers):
HTTP1 compatibility aka ALPN negotiation (blocked on http module implementation):
WebSocket Proxing using RFC8441 (disable by default on node.js);
ALTSVC using RFC7838:
In-Progress:
Progress:
Class: ServerHttp2Session
Class: ClientHttp2Session
Class: Http2Stream
Class: ClientHttp2Stream
Class: ServerHttp2Stream
Class: Http2Server
Class: Http2SecureServer
Module:
Compatibility API
Class: http2.Http2ServerRequest
Class: http2.Http2ServerResponse
How did you verify your code works?