Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test coverage to the project. #2619

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

huxaiphaer
Copy link

PR Status : (Work in progress)
What does this PR do ?

  • Adding test coverage to the project, to ensure that we track the tested edge cases.
    Tool/ Library used
  • Jacoco

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


huxaiphaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

Thanks for your contribution. We will check it and let you know our feedback.

If you plan to contribute to the app, i encourgae you to read our contributing file: https://github.com/owncloud/android/blob/master/CONTRIBUTING.md

and also i remember you must sign the CLA: https://cla-assistant.io/owncloud/android?pullRequest=2619

welcome!

@huxaiphaer
Copy link
Author

huxaiphaer commented Aug 6, 2019

Hello @jesmrec , thanks for the feedback, but regarding CLA, I registered several times but there wasn't a reflecting on my PR. I don't know if this is a bug. Then secondly, is there a way developers can login with a testing server link, I didn't see it mentioned in the SETUP.md

@jesmrec
Copy link
Collaborator

jesmrec commented Aug 6, 2019

demo.owncloud.com is a testing server, with credentials demo/demo.

About CLA, any idea about @michaelstingl ?

@DeepDiver1975
Copy link
Member

huxaiphaer seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

Please follow the instructions as posted by the CLA bot - THX

@jesmrec jesmrec added this to the 2.13.0 milestone Aug 13, 2019
@jesmrec jesmrec self-assigned this Aug 20, 2019
@jesmrec
Copy link
Collaborator

jesmrec commented Aug 27, 2019

Some considerations

  • build.gradle is actually conflicting in the current PR, could you take a look?

  • I checked your code, and noticed that the tool is triggered by Travis. We are going to drop Travis as CI to use BitRise instead, which does not need yml file. So, we need to get a different way to trigger, if feasible

  • By triggering gradlew locally (same job tu set up in Travis if [ -e ./gradlew ]; then ./gradlew jacocoTestReport;else gradle jacocoTestReport;fi, no reports were generated in my machine neither in build/reports/ folder not in other one. Do i miss something? i would like to check in the project to evaluate how deep and interesting are the reports for us.

when these ones are fixed, we can keep checking if the tool fits our necessities. If you need something in which we can help you, let us know @huxaiphaer. Thanks a lot again!

@jesmrec jesmrec modified the milestones: 2.13.0, backlog Sep 23, 2019
@JuancaG05 JuancaG05 removed this from the backlog milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants