Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update scalafmt-core to 3.5.3 #458

Conversation

scala-steward
Copy link
Contributor

Updates org.scalameta:scalafmt-core from 3.5.2 to 3.5.3.
GitHub Release Notes - Version Diff

I'll automatically update this PR to resolve conflicts as long as you don't change it yourself.

If you'd like to skip this version, you can just close this PR. If you have any feedback, just mention me in the comments below.

Configure Scala Steward for your repository with a .scala-steward.conf file.

Have a fantastic day writing Scala!

Adjust future updates

Add this to your .scala-steward.conf file to ignore future updates of this dependency:

updates.ignore = [ { groupId = "org.scalameta", artifactId = "scalafmt-core" } ]

Or, add this to slow down future updates of this dependency:

dependencyOverrides = [{
  pullRequest = { frequency = "@monthly" },
  dependency = { groupId = "org.scalameta", artifactId = "scalafmt-core" }
}]

labels: library-update, early-semver-patch, semver-spec-patch, commit-count:n:2

build.sbt Outdated
@@ -4,6 +4,43 @@ import Common._
import com.typesafe.tools.mima.core._
import com.typesafe.tools.mima.plugin.MimaKeys.{ mimaBinaryIssueFilters, mimaPreviousArtifacts }

// Customise sbt-dynver's behaviour to make it work with tags which aren't v-prefixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would rather keep it in version.sbt

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you insist, ok, we can keep it there. (In all the other Play repos we removed version.sbt to make clear we now use sbt-dynver, and also keep the dynver configs in build.sbt)
Long term solution however IMHO is that we add a config to sbt-dynver to achieve what you did here: sbt/sbt-dynver#227 (if you want you can provide a PR to sbt-dynver 😉 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why having everything in build.sbt rather than modular files would make it clear?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anorm Reverted here: #461

@mkurz mkurz closed this May 19, 2022
@scala-steward
Copy link
Contributor Author

Superseded by #470.

@scala-steward scala-steward deleted the update/scalafmt-core-3.5.3 branch July 10, 2022 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants