Skip to content

Commit

Permalink
drm/vc4: Add a delay after disabling hdmi phy output
Browse files Browse the repository at this point in the history
There appears to be a requirement for some devices
(I'm testing with a 8K VRROOM 40Gbps HDMI switch)
for a measable delay between removing the hdmi phy output from
the old mode, to enabling the hdmi phy output for the new mode.

Without the delay, a mode switch has a small change of getting a permanent
'no signal', which requires a subsequent mode switch or a unplug/replug
to redetect.

Switching between 4kp24/25/30 modes fails about 5% of time in my testing.

Add a delay to make it impossible to switch faster than this.

Signed-off-by: Dom Cobley <[email protected]>
  • Loading branch information
popcornmix committed Aug 13, 2024
1 parent bfaaf1b commit 733e7a5
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/gpu/drm/vc4/vc4_crtc.c
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ static void vc4_crtc_atomic_disable(struct drm_crtc *crtc,
* someone was waiting it.
*/
vc4_crtc_send_vblank(crtc);
msleep(20);
}

static void vc4_crtc_atomic_enable(struct drm_crtc *crtc,
Expand Down

0 comments on commit 733e7a5

Please sign in to comment.