General cleanup #1988
Merged
General cleanup #1988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LilSpazJoekp
force-pushed
the
general-cleanup
branch
2 times, most recently
from
9e86455
to
82f226d
Compare
bboe
reviewed
Oct 22, 2023
| msg = "Either id or _data needs to be given." | ||
| raise ValueError(msg) | ||
|
|
||
| if reason_id: | ||
| self.id = reason_id | ||
| if _reason_id: |
There was a problem hiding this comment.
Since you are using this value, it seems a little strange to _ prefix it.
There was a problem hiding this comment.
I think a linter was whining about it possibly mutating reason_id. Looking at self._warn_reason_id, that shouldn't be an issue.
bboe
approved these changes
Oct 22, 2023
LilSpazJoekp
force-pushed
the
general-cleanup
branch
from
82f226d
to
39270a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General codebase cleanup