Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(issue-12348): add validator index label to validator_statuses me… #14473

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

0xste
Copy link

@0xste 0xste commented Sep 24, 2024

What type of PR is this?
Feature

What does this PR do? Why is it needed?

  • We don't currently have a way to retrieve validator index from prometheus
  • It's useful for joining to various other metrics and, an example use-case is linking from a dashboard using the index as part of the target link i.e. https://beaconcha.in/validator/1101253 or joining with another metric to get additional metadata
  • This has been added to the existing validator_statuses metric:
    • We don't have a redundant info metric & associated cardinality
    • We make a non-breaking change to the metric contract for the existing validator_statuses metric by adding an additional label

Which issues(s) does this PR fix?
Fixes #12348

Acknowledgements

  • I have read CONTRIBUTING.md.
  • I have made an appropriate entry to CHANGELOG.md.
  • I have added a description to this PR with sufficient context for reviewers to understand this PR.

@0xste 0xste requested a review from a team as a code owner September 24, 2024 11:31
prestonvanloon
prestonvanloon previously approved these changes Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export metric for validator_identity and include index
2 participants