Execution API Electra: requests as a sidecar #14492
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james-prysm
commented
Sep 30, 2024
| } | ||
|
|
||
| // ExecutionEnvelopeElectra is a container that builds on Payload V4 and includes execution requests sidecar needed post Electra | ||
| message ExecutionEnvelopeElectra { |
There was a problem hiding this comment.
should I call it something else?
There was a problem hiding this comment.
conflicts with epbs, i should rename
There was a problem hiding this comment.
I think naming it mentioning electra is self explanatory to me like we have simple ExecutionPayloadEnvelope so in my views its ok to keep this naming
james-prysm
commented
Sep 30, 2024
| bytes value = 2; | ||
| BlobsBundle blobs_bundle = 3; | ||
| bool should_override_builder = 4; | ||
| repeated bytes execution_requests = 5; |
There was a problem hiding this comment.
double check if the type and size are correct
saolyn
reviewed
Oct 1, 2024
| @@ -259,6 +259,9 @@ func (s *Service) ForkchoiceUpdated( | |||
|
|
|||
| func getPayloadMethodAndMessage(slot primitives.Slot) (string, proto.Message) { | |||
There was a problem hiding this comment.
A bit of a nit, would this be better/clearer as a switch?
func getPayloadMethodAndMessage(slot primitives.Slot) (string, proto.Message) {
pe := slots.ToEpoch(slot)
switch {
case pe >= params.beaconConfig().ElectraForkEpoch:
return GetPayloadMethodV4, &pb.ExecutionEnvelopeElectra{}
case pe == params.beaconConfig().DenebForkEpoch:
return GetPayloadMethodV3, &pb.ExecutionPayloadDenebWithValueAndBlobsBundle{}
case pe == params.beaconConfig().CapellaForkEpoch:
return GetPayloadMethodV2, &pb.ExecutionPayloadCapellaWithValue{}
default:
return GetPayloadMethod, &pb.ExecutionPayload{}
}
}
There was a problem hiding this comment.
I think it's about the same but can update
james-prysm
changed the title
james-prysm
commented
Oct 2, 2024
| } | ||
| pr := common.Hash(blk.Block().ParentRoot()) | ||
| // TODO: get encoded hash for execution requests | ||
| executionRequestsHash := &common.Hash{} |
There was a problem hiding this comment.
maybe we don't want to do this
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
implements ethereum/execution-apis#591
engine_newPayloadV4andengine_getPayloadV4Which issues(s) does this PR fix?
Fixes #
Other notes for review
Acknowledgements