Store plugin's by name rather than path #23386
Conversation
|
This change breaks the abi. Can u use the R2_USE_NEW_ABI ? |
|
Alright, wasn't aware of that define, I'll look into it in the coming days. |
|
As long as this is a rather large PR changing the abi of rparse i dont think it makes sense to use the new-abi define. so i think it's better to hold this PR until 5.9.9 is in dev. (we need to release 5.9.6 and 5.9.8 before reaching the abi breaking seasson). Apart from that i think the change makes sense and seems reasonable. I want to perform more changes in the rparse api, so i wanted to have some time before the 5.9.9 time arrives to do that. what do you think? as long as we are not gonna break abi, this pr shouldnt be affected by any change until the time arrives. also, do u think the getname callback is necessary? because if all the plugins use the rpluginmeta now, we can just assume this struct on all of them and not depend on helper functions to do that. |
- Make parse/bp plugins use RPluginMeta - Print plugin path with Lcj - Use plugin name as opposed to the filename to detect if a plugin has already been loaded.
|
You're right about the getname callback, I removed it. I'll try to write some tests for this at some point. I'm afraid this change might break some plugins that are outside the r2 repo though. Are you aware of any bp/parse plugins "external" to r2 or how I can find them? |
|
Theres inly afen. An external parse plugin. Dont know any about bp |
Description
So I was looking at #22445 and I figured it would be interesting to store plugins in the hash table by their names instead of their paths.
It makes it easier to detect duplicates and easier to get the path from which the plugin was loaded, but this is more of a proposition.
Code is a little awkward in some places, looking for feedback.