Draft: Multibyte wb support #23430
Open
Draft: Multibyte wb support #23430
+130
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jukuisma
force-pushed
the
feature-multibyte-wb
branch
from
4848cfc
to
3a4e307
Compare
|
TODO:
|
jukuisma
commented
Oct 7, 2024
Comment on lines
+2206
to
+2208
| // TODO: Do we need some bound check for | ||
| // `core->offset + block_offset`? Other | ||
| // functions don't seem to implement any. |
jukuisma
commented
Oct 7, 2024
trufae
reviewed
Oct 7, 2024
libr/core/cmd_write.inc.c
Outdated
| for (i = 0; i < uil; i++) { | ||
| c = input[i]; | ||
| // Ignore whitespaces, \r and \n chars | ||
| if (c == ' ' || c == '\r' || c == '\n') { |
There was a problem hiding this comment.
Use isspace() its more portable and fast and comes with libc. Also handles tab
There was a problem hiding this comment.
trufae
reviewed
Oct 7, 2024
libr/core/cmd_write.inc.c
Outdated
| continue; | ||
| } | ||
| // Check that user input only contains ones and zeros | ||
| else if (c != '0' && c != '1') { |
There was a problem hiding this comment.
No need for else after continue
There was a problem hiding this comment.
jukuisma
force-pushed
the
feature-multibyte-wb
branch
2 times, most recently
from
5e9ade2
to
a39784e
Compare
jukuisma
force-pushed
the
feature-multibyte-wb
branch
from
a39784e
to
f5561b0
Compare
|
Lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description