-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
overlays: Add Pineboards HatDrive! POE+ #6257
overlays: Add Pineboards HatDrive! POE+ #6257
Conversation
You've got a few things to fix: https://github.com/raspberrypi/linux/actions/runs/9828536077/job/27132619672?pr=6257#step:4:515 |
53cf8f7
to
4c3f6c5
Compare
Tabs vs spaces... Thanks for letting me know. Pushed again. One thing to confirm - is hat_current_supply sufficient for the 5A input or should I add something else to remove the USB power limit that is active by default when the official USB-C PD is detected? |
I think it's sufficient. You can confirm by looking in /chosen/power/*:
|
How old is your EEPROM image? 2024-04-05 (raspberrypi/rpi-eeprom@d8abe8c) is the first version with full HAT+ support. |
|
Does your HAT declare itself to be a stackable HAT+ by using an EEPROM address of 0x51, 0x52 or 0x53? It looks as though, using the current sequence of operations, a |
I think it does, but I'll check the schematic tomorrow to be sure. This part hasn't changed from the OG HatDrive! Top and it has the same config as your official M.2 HAT+. I can also modify the addresses or disconnect the EEPROM completely. BTW, if this is an issue in the firmware it also won't work fine on the Pironman overlay that was merged recently since it also sets the current in a similar way. With the current overlay I can draw around 22W through PoE+ with a high power USB device connected and the Pi 5 overlocked (100% CPU load). I could push it a little further with the official PSU, that's why I started looking into USB current limits. |
@pelwell confirmed, we are using 0x51. In my test setup I've set the dtoverlay in config.txt (the HAT is not flashed) |
That definitely won't work at present. Please flash the EEPROM so we can confirm that everything else works. |
It looks like there is some confusion here over In an ideal world, one might want the firmware to:
However, the fact that the overlays may be loaded from USB causes a chicken-and-egg problem - it's not possible to know that an overlay enables USB booting before USB booting has loaded the overlay. Instead, the presence of a Mode 1 Power HAT+ EEPROM address is used to indicate the presence of a high current supply. The value of If your POE+ HAT+ uses address 0x53, |
@sunfounder FYI. |
We’ll change the address tomorrow and test again. Thanks for the info!
Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
…________________________________
Od: Phil Elwell ***@***.***>
Wysłane: Tuesday, July 9, 2024 5:48:32 PM
Do: raspberrypi/linux ***@***.***>
DW: Michał Gapiński ***@***.***>; Author ***@***.***>
Temat: Re: [raspberrypi/linux] overlays: Add Pineboards HatDrive! POE+ (PR #6257)
the Pironman overlay that was merged recently since it also sets the current in a similar way.
@sunfounder<https://github.com/sunfounder> FYI.
—
Reply to this email directly, view it on GitHub<#6257 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHDCB7DCSY75SFTFGUPJ7DZLQA5BAVCNFSM6AAAAABKPO34TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGA3DCNJRGQ>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
We've had a major documentation logjam, but I hope that when the final HAT+ doc comes out it is much clearer about the Device Tree semantics. |
It makes our job a little more interesting when we have to dig deeper or guess what the schematics are 😅 that's how it all started for us last year.
With the HAT+ address changed do we still need the overlay? It's not a problem but if we can save some time on programming the boards in production we'll do it. Our POE+ HAT doesn't really need anything more than a 5A power limit
Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
…________________________________
Od: Phil Elwell ***@***.***>
Wysłane: Tuesday, July 9, 2024 5:58:54 PM
Do: raspberrypi/linux ***@***.***>
DW: Michał Gapiński ***@***.***>; Author ***@***.***>
Temat: Re: [raspberrypi/linux] overlays: Add Pineboards HatDrive! POE+ (PR #6257)
We've had a major documentation logjam, but I hope that when the final HAT+ doc comes out it is much clearer about the Device Tree semantics.
—
Reply to this email directly, view it on GitHub<#6257 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAHDCB2IYXPHTABZNIPXOVLZLQCD5AVCNFSM6AAAAABKPO34TWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMJYGA4DEMRUGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
I can't see how not including the name of the overlay in the EEPROM image could save more than milliseconds of programming time. The only way to make a real saving is to not have (or not program) the EEPROM, but then it wouldn't be a HAT+. |
There's a trial EEPROM image that makes the handling of overlays from the different flavours of HAT+ consistent, but as discussed previously that hat_current_supply is only a description of the power capabilities for userspace. Only MODE1 power HAT+s actually enable USB booting. The recovery-style .zip is available here: https://drive.google.com/file/d/1uVhO08f09L2JzATppjlinGTpCeaTneup/view?usp=drive_link |
Thank you! We changed the address on our board but I am yet to test it. We're entering production very soon, so I'll test everything and get back to you after the weekend. |
@pelwell Thanks for the guidance, I just tested a final board with an 0x53 address, written the EEPROM with the overlay name from this PR and it worked flawlessly:
It looks like the overlay can be merged as is, hopefully it'll reach stable soon enough. We're hoping to launch the board in ~1 month |
I'll merge it once you've added the extra blank lines between entries, as flagged up by the build checks: https://github.com/raspberrypi/linux/actions/runs/9840009688/job/27170998817?pr=6257#step:4:515 |
@pelwell I've added the blank lines + synced with the base branch |
arch/arm/boot/dts/overlays/README
Outdated
@@ -3703,6 +3703,12 @@ Load: dtoverlay=pineboards-hat-ai | |||
Params: <None> | |||
|
|||
|
|||
Name: pineboards-hatdrive-poe-plus | |||
Info: Configures the Pineboards HatDrive! PoE+ | |||
Load: dtoverlay=pineboards-hat-ai |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be "dtoverlay=pineboards-hatdrive-poe-plus"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missed that, updated
Fix overlay name for pineboards-hatdrive-poe-plus
overlays: Add Pineboards HatDrive! POE+
overlays: Add Pineboards HatDrive! POE+
… at 2GB See: raspberrypi/linux#6392 kernel: overlays: Add Pineboards HatDrive! POE+ See: raspberrypi/linux#6257 kernel: Revert switch to upstream HAT patches See: raspberrypi/linux#6393 kernel: dts: overlay_map: ramoops-pi4 works on Pi 5 See: raspberrypi/linux#5298
… at 2GB See: raspberrypi/linux#6392 kernel: overlays: Add Pineboards HatDrive! POE+ See: raspberrypi/linux#6257 kernel: Revert switch to upstream HAT patches See: raspberrypi/linux#6393 kernel: dts: overlay_map: ramoops-pi4 works on Pi 5 See: raspberrypi/linux#5298
overlays: Add Pineboards HatDrive! POE+
overlays: Add Pineboards HatDrive! POE+
overlays: Add Pineboards HatDrive! POE+
overlays: Add Pineboards HatDrive! POE+
This overlay sets sets the current supply to 5A on the upcoming Pineboards HatDrive! POE+ board.
cc @pelwell