drivers: media: imx500: Simplify the vblank control init #6388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set the VBLANK control minimum and default values to IMX500_VBLANK_MIN unconditionally everywhere. Remove the mode specific framerate_default parameter, it is now unused. Signed-off-by: Naushir Patuck <[email protected]>
roliver-rpi
approved these changes
Sep 26, 2024
6by9
approved these changes
Sep 26, 2024
|
|
||
| /* Setting this will adjust the exposure limits as well. */ | ||
| __v4l2_ctrl_s_ctrl(imx500->vblank, frm_length_default - mode->height); | ||
| __v4l2_ctrl_s_ctrl(imx500->vblank, IMX500_VBLANK_MIN); |
There was a problem hiding this comment.
Technically not needed as __v4l2_ctrl_modify_range will update the value if the current value is out of range and call s_ctrl.
There was a debate previously over whether setting the mode should reset the frame rate controls or not, but I don't think there was ever a final decision.
There was a problem hiding this comment.
Agree, but I'd prefer to leave it in to preserve existing code that I've been testing with 😄
popcornmix
added a commit
to raspberrypi/firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
popcornmix
added a commit
to raspberrypi/rpi-firmware
that referenced
this pull request
Sep 26, 2024
See: raspberrypi/linux#6368 kernel: tty/serial: pl011: Also unregister pl011_axi_platform_driver See: raspberrypi/linux#6380 kernel: overlays: wm8960-soundcard: Fix clock declaration See: raspberrypi/linux#6387 kernel: Fix speaker disabling issue after closing microphone app See: raspberrypi/linux#6383 kernel: ASoC: bcm2835-i2s: Set the PERIOD_BYTES min to 256 See: raspberrypi/linux#6386 kernel: drivers: media: imx500: Simplify the vblank control init See: raspberrypi/linux#6388
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the VBLANK control minimum and default values to IMX500_VBLANK_MIN unconditionally everywhere.
Remove the mode specific framerate_default parameter, it is now unused.