Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uConsole driver support #6403

Open
wants to merge 2 commits into
base: rpi-6.6.y
Choose a base branch
from

Conversation

crossplatformdev
Copy link

No description provided.

@pelwell
Copy link
Contributor

pelwell commented Oct 6, 2024

We don't normally take whole drivers for devices which aren't Pi-exclusive, and certainly not without a lot more information.

@crossplatformdev
Copy link
Author

crossplatformdev commented Oct 6, 2024

These PR is a rpi-6.6.y base with @oesmith patch:
https://raw.githubusercontent.com/oesmith/uconsole/refs/heads/main/kernel/clockworkpi-kernel-6.6.patch

Extracted from @ak-rex's kernel fork:
https://github.com/ak-rex/ClockworkPi-linux/commits/rpi-6.6.y/

That allows CM4 to be used with the uConsole landing board, screen, battery, and other drivers.

@clockworkpi's uConsole description is below:
https://www.clockworkpi.com/product-page/uconsole-kit-rpi-cm4-lite

@6by9
Copy link
Contributor

6by9 commented Oct 7, 2024

Panel drivers want to go upstream, and would need devicetree bindings.
CWD686 panel driver has been sent before at https://patchwork.freedesktop.org/patch/503489/, but no v4 ever seemed to appear.

The change to vc4_dsi.c I'd want some more description on - I'm not aware of any issue in coming out of ULPS mode from power on, and ULPS isn't used at any other time now.

ACP20 driver changes would want to go upstream too with justification.

Backlight driver wants to go upstream. Based on the datasheet I found it's a 1-wire interface, so should ideally be using the 1-wire support rather than bit-bashing.

bcm2835-audio change is wrong as it should be handled by updating the kernel command line in device tree.

Any patch should be a single self-contained entity, one per driver or per feature being added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants