[Feat][kubectl-plugin] Add kubectl ray version command #2424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsykim
reviewed
Oct 3, 2024
Closes: ray-project#2423 Signed-off-by: Chi-Sheng Liu <[email protected]>
MortalHappiness
force-pushed
the
feature/#2423-kubectl-ray-version
branch
from
27040b0
to
86a9f3d
Compare
kevin85421
reviewed
Oct 4, 2024
| @@ -16,6 +16,7 @@ builds: | |||
| - arm64 | |||
| main: ./cmd | |||
| binary: kubectl-ray | |||
| ldflags: -X github.com/ray-project/kuberay/kubectl-plugin/pkg/cmd/version.Version={{- .Tag -}} | |||
There was a problem hiding this comment.
A git tag, semver tag. e.g. v1.0.0
| "github.com/spf13/cobra" | ||
| ) | ||
|
|
||
| var Version = "development" |
There was a problem hiding this comment.
Suggested change
| var Version = "development" | |
| const Version string = "development" |
There was a problem hiding this comment.
This cannot be replaced with const. This variable will be override by ldflags at build time.
|
|
kevin85421
approved these changes
Oct 4, 2024
andrewsykim
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
See the description in the corresponding issue for details.
Related issue number
Closes: #2423
Checks