Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade: React 18 packages #165

Open
wants to merge 1 commit into
base: react-18
Choose a base branch
from

Conversation

ramazansancar
Copy link

No description provided.

Copy link
Member

@ncw ncw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This contains a lot of changes which aren't to do with upgrading to react-18.

I see some refactoring, some css styling changes, some code formatting changes all mixed in with the upgrade to the packages.

Ideally I'd like to see these in individual commits, starting with the minimum needed to upgrade to react 18 - otherwise this is very difficult to review.

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants