Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flake: Attempt at fixing Personalize configuration #6830

Conversation

valaparthvi
Copy link
Contributor

What type of PR is this:

What does this PR do / why we need it:

Which issue(s) this PR fixes:

Fixes #

PR acceptance criteria:

  • Unit test

  • Integration test

  • Documentation

How to test changes / Special notes to the reviewer:

@openshift-ci openshift-ci bot requested review from feloy and rnapoles-rh May 22, 2023 03:53
@netlify
Copy link

netlify bot commented May 22, 2023

Deploy Preview for odo-docusaurus-preview canceled.

Name Link
🔨 Latest commit 75dc7a6
🔍 Latest deploy log https://app.netlify.com/sites/odo-docusaurus-preview/deploys/649d79fe9af381000879e743

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

NoCluster Tests on commit 714a1ae finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

OpenShift Unauthenticated Tests on commit 714a1ae finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Unit Tests on commit 714a1ae finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Validate Tests on commit d6470ba finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Kubernetes Tests on commit 714a1ae finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Windows Tests (OCP) on commit 714a1ae finished with errors.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

OpenShift Tests on commit 714a1ae finished successfully.
View logs: TXT HTML

@odo-robot
Copy link

odo-robot bot commented May 22, 2023

Kubernetes Docs Tests on commit 6a4e964 finished successfully.
View logs: TXT HTML

@valaparthvi
Copy link
Contributor Author

Podman failure:

  ✓  Deleting resources from podman [12s]
  [odo] The component "pfydfi" is successfully deleted from podman
  [odo] I0522 04:09:15.094697  139220 podman.go:195] Deleted volume odo-shared-data-pfydfi-app
  Setting current dir to: /home/runner/work/odo/odo/tests/integration
  Deleting dir: /tmp/975753024
  Deleting dir: /tmp/3047114366
  << Timeline

  [FAILED] Expected
      <string>: Searching resources to delete, please wait...
      No resource found for component "pfydfi"
      
      
  to contain substring
      <string>: - pfydfi
  In [It] at: /home/runner/work/odo/odo/tests/integration/cmd_delete_test.go:279 @ 05/22/23 04:08:58.189
------------------------------
SSSSSSSSSS•SSS••SSS•SSSSSS•SSSSSSSSS••SS•SSSS•SSSSSSSSSSS•S••SSSSSSSSSSSSS•SSSSS•SSSS•SSSSSS•SSSS•S•SSSS••SS•SSSS•SSS•S•SSSS•SSSSSSSSSSS•SSSSSSSSSSSSS•SSSSS•SSSSSSSSSSSSSSSSSSS••SSSSS•SSSSSSS•SSS••SSSSSSSSSSSSSSS•SSS•SSSSSSS•SSS•SS•SSS•SSSSSS•S•••SSSSSSSSSSSSSSSSSSSSSSSS•SSSSSSSSSS•••S•SSSSSSSSSSSSSS•SSSSSS•SSSSSSSSSSS•SSSSSSSS••SSSSS•SSSS••SSSS•S•S•SSSSSS•SS•SSSSS•SSSSSSSSSSSS•SSSSSSSSSSS•SSSSSSSSSSSS•SSS•SS•S•SSSSSS•S•SSS•SSSSSSSSSSSSSS••SSSS•SSSS•S•SSSSSS••••••••••

Summarizing 1 Failure:
  [FAIL] odo delete command tests when a component is bootstrapped when the component is deployed in DEV mode and dev mode stopped when the component is deleted using its name (and namespace) from another directory (running-in="") [It] should have deleted the component [podman]

Rerunning the job.

@feloy
Copy link
Contributor

feloy commented Jun 6, 2023

The test is still flaky:

 > Delete environment variable "DEBUG_PORT"
  ? What configuration do you want change? Delete environment variable "DEBUG_PORT"  [Use arrows to move, type to filter]
  > Delete environment variable "DEBUG_PORT"
  ? What configuration do you want change? Delete environment variable "DEBUG_PORT"
  ? What configuration do you want change?  [Use arrows to move, type to filter]
  > NOTHING - configuration is correct
    Delete port "5858"
    Delete port "5000"
    Add new port
    Delete environment variable "DEBUG_PROJECT_PORT"
    Add new environment variable
  
  ======================
  Unexpected error:
      <*xpty.errPassthroughTimeout | 0xc001d6c010>: {
          error: <*errors.errorString | 0xc001d6c000>{
              s: "passthrough i/o timeout",
          },
      }
      passthrough i/o timeout
  occurred
  In [It] at: /go/odo_1/tests/helper/helper_interactive.go:111 @ 06/06/23 08:31:53.33

@rm3l rm3l added the area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering label Jun 19, 2023
@valaparthvi valaparthvi requested review from rm3l and removed request for rnapoles-rh June 23, 2023 09:08
@valaparthvi valaparthvi reopened this Jun 27, 2023
Signed-off-by: Parthvi Vala <[email protected]>
Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi valaparthvi changed the title Flake: Attempt at fixing Personalize configuration [WIP] Flake: Attempt at fixing Personalize configuration Jun 27, 2023
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 27, 2023
@rm3l rm3l mentioned this pull request Jun 27, 2023
3 tasks
Signed-off-by: Parthvi Vala <[email protected]>
@valaparthvi valaparthvi changed the title [WIP] Flake: Attempt at fixing Personalize configuration Flake: Attempt at fixing Personalize configuration Jun 29, 2023
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. Required by Prow. label Jun 29, 2023
@feloy feloy closed this Jun 29, 2023
@feloy feloy reopened this Jun 29, 2023
@feloy feloy closed this Jun 29, 2023
@feloy feloy reopened this Jun 29, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

Copy link
Contributor

@feloy feloy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix @valaparthvi

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. Required by Prow. label Jun 29, 2023
@feloy
Copy link
Contributor

feloy commented Jun 29, 2023

/override windows-integration-test/Windows-test

Not related

@openshift-ci
Copy link

openshift-ci bot commented Jun 29, 2023

@feloy: Overrode contexts on behalf of feloy: windows-integration-test/Windows-test

In response to this:

/override windows-integration-test/Windows-test

Not related

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit a10f693 into redhat-developer:main Jun 29, 2023
5 checks passed
@rm3l rm3l added this to the v3.13.0 🚀 milestone Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing, Quality Assurance or Quality Engineering flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. Required by Prow.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants