Dataframe v2: support for filtered_index_values
#7589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teh-cmc
added
enhancement
teh-cmc
force-pushed
the
cmc/dataframev2_filtered_index_values
branch
from
be7eaaf
to
12852da
Compare
6 tasks
jleibs
approved these changes
Oct 4, 2024
| @@ -527,6 +527,13 @@ impl QueryHandle<'_> { | |||
| .min_by_key(|streaming_state| streaming_state.index_value) | |||
| .map(|streaming_state| streaming_state.index_value)?; | |||
|
|
|||
| if let Some(filtered_index_values) = self.query.filtered_index_values.as_ref() { | |||
| if !filtered_index_values.contains(&cur_index_value) { | |||
| self.increment_cursors_at_index_value(cur_index_value); | |||
There was a problem hiding this comment.
I know we're not optimizing yet... but it seems like this could take an optional next_index_value which we can easily look up from filtered_index_values. Then we could just increment repeatedly in the inner increment as long as we're less than next_index_value.
Additionally, if we made increment_cursors_at_index_value() return the minimum value across all the chunks, we could loop here and basically guarantee that the call to next_row() will end up with a value included in filtered_index_values
There was a problem hiding this comment.
Index sampling and clear/tombstone support first -- I don't want to optimize myself into a corner because of weird interactions with other features...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title.
Checklist
mainbuild: rerun.io/viewernightlybuild: rerun.io/viewerCHANGELOG.mdand the migration guideTo run all checks from
main, comment on the PR with@rerun-bot full-check.