Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve node.name parsing, fix silent errors #28

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve node.name parsing, fix silent errors #28

wants to merge 2 commits into from

Conversation

hhsnopek
Copy link

closes #27

@coveralls
Copy link

Coverage Status

Coverage decreased (-43.8%) to 56.25% when pulling 69c20b7 on carrot:master into 3d660b6 on reshape:master.

@hhsnopek hhsnopek changed the title improve node.name parsing, fix silent errors [WIP] improve node.name parsing, fix silent errors Nov 29, 2017
@hhsnopek hhsnopek changed the title [WIP] improve node.name parsing, fix silent errors improve node.name parsing, fix silent errors Nov 29, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 99.107% when pulling c492c03 on carrot:master into 3d660b6 on reshape:master.

@jescalan
Copy link
Member

Looking great so far, thank you! Could you take a look at that coverage decrease?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e2a801a on carrot:master into 3d660b6 on reshape:master.

@hhsnopek
Copy link
Author

@jescalan coverage has been restored to 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SVGO Errors are slient
3 participants
@hhsnopek @coveralls @jescalan