Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix name size from edit preset (in backend and frontend). #848

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix name size from edit preset (in backend and frontend). #848

wants to merge 4 commits into from

Conversation

CherifAmine
Copy link
Contributor

Description

Fix size name from edit preset (in backend and frontend).

Changes Made

Added data validation for name size in the backend and in the frontend.

Closes Issue(s)

Related Issue(s)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Automated testing implementation or update
  • Dependencies updated to a newer version
  • Documentation update
  • Experimental feature that requires further discussion

Screenshots and screen captures

@CherifAmine CherifAmine mentioned this pull request Jul 27, 2023
Open
@CherifAmine CherifAmine added the component: presets Changes related to predefined settings or configurations. label Jul 27, 2023
@marwa-benhassine marwa-benhassine added the quality control: changes requested Approved (for when the QA testing team approves the changes) label Jul 27, 2023
@marwa-benhassine
Copy link
Contributor

marwa-benhassine commented Jul 27, 2023 •
edited
Loading

@CherifAmine
there are movements when renaming the presets name

Movement popup rename name

@marwa-benhassine
Copy link
Contributor

when you click the submit button the preset name input is enlarged

the validation error message of the prset name appears in two stages

input popup

@marwa-benhassine
Copy link
Contributor

the validation error message of the prset name appears in two stages
validate error message

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
15.3% 15.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@marwa-benhassine marwa-benhassine added quality control: approved Changes Requested (for feedback from the QA testing team) quality control: changes requested Approved (for when the QA testing team approves the changes) and removed quality control: changes requested Approved (for when the QA testing team approves the changes) quality control: approved Changes Requested (for feedback from the QA testing team) labels Jul 28, 2023
@marwa-benhassine
Copy link
Contributor

The validation error message should be global and displayed above the form like the validation message in installer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GhaziTriki GhaziTriki Awaiting requested review from GhaziTriki

@hanazarraa hanazarraa Awaiting requested review from hanazarraa

Assignees

@marwa-benhassine marwa-benhassine

Labels
component: presets Changes related to predefined settings or configurations. quality control: changes requested Approved (for when the QA testing team approves the changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CherifAmine @marwa-benhassine