Made masscan compatible to C++ compilers #585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* mostly cast fixes for malloc * typed some ints to the correct enums, which also benefits clarity * fixed some other variables types and eliminated some UB as signed-unsigned comparison * added a missing check for a returned value * made signatures consistent (plain C is shit that ignores the inconsistencies, that can cause hard-to-debug errors, it is another reason to never use plain C compiler) * added some abstraction layer addressing the deprecations in C++ >=17 Also the editor has removed the unneeded whitespaces, it was noticed too late to address, so let these changes be here too.
KOLANICH
force-pushed
the
cpp_compatibility
branch
from
de79e6d
to
792e0e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also the editor has removed the unneeded whitespaces, it was noticed too late to address, so let these changes be here too.