[CI] Specify runner/container images and add Jazzy #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
jaron-l,
olivier-stasse,
peterdavidfagan and
VX792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69 +/- ##
==========================================
+ Coverage 71.50% 80.68% +9.18%
==========================================
Files 4 4
Lines 200 176 -24
Branches 134 17 -117
==========================================
- Hits 143 142 -1
Misses 25 25
+ Partials 32 9 -23
Flags with carried forward coverage won't be shown. Click here to find out more. |
fmauch
reviewed
Apr 24, 2024
|
@Mergifyio backport humble |
✅ Backports have been created
|
fmauch
approved these changes
Apr 24, 2024
olivier-stasse
approved these changes
Apr 25, 2024
christophfroehlich
changed the title
fmauch
approved these changes
May 7, 2024
There was a problem hiding this comment.
Without ros-controls/ros2_control_ci#72 changes seem fine, hence approving. However, if that is going to be merged it would probably be good to alter this PR accordingly.
mergify bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Specify runner/container images * use correct matrix strategy * Fix ref for source build * Add jazzy * Update upstream pre-commit wf * Update upstream pre-commit wf also for rolling * Update coverage build inputs (cherry picked from commit 24174a4)
christophfroehlich
added a commit
that referenced
this pull request
May 8, 2024
[CI] Specify runner/container images and add Jazzy (#69) * Specify runner/container images * use correct matrix strategy * Fix ref for source build * Add jazzy * Update upstream pre-commit wf * Update upstream pre-commit wf also for rolling * Update coverage build inputs (cherry picked from commit 24174a4) Co-authored-by: Christoph Fröhlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jobs for jazzy-main are failing, but jazzy-testing works fine already.