Improve error output on upload #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| extraneous_packages = set(changefiles) - set(valid_changes) | ||
| if extraneous_packages: | ||
| parser.error("Invalid packages detected in folders %s. [%s]" % | ||
| (options.folders, extraneous_packages)) |
There was a problem hiding this comment.
What's the difference between extraneous and invalid packages?
There was a problem hiding this comment.
extraneous is a set of ChangesFile objects that indicate which changes files are problematic. invalid_changes is new; it's a list of the binary package names from within those changes files that were declared be be invalid.
The result here is that the error output is now something like [ ['python-foo-bar'] ] instead of [ ChangesFile(...) ]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two patches: