Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update system.yaml #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update system.yaml #206

wants to merge 1 commit into from

Conversation

mosfet80
Copy link

switch to node.js20 (node<20 is deprecated)

clalancette
clalancette requested changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me, but can you please sign-off your commit? Locally, you should be able to do something like:

git commit --amend -s
git push -f

@mosfet80 mosfet80 force-pushed the patch-1 branch 2 times, most recently from b08363a to cace9f5 Compare September 12, 2024 04:23
@mosfet80
Update system.yaml
cace9f5 
switch to node.js20  (node<20 is deprecated)

Signed-off-by: Andrea <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mosfet80 @clalancette