Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install headers to include/${PROJECT_NAME} #46

Merged
merged 2 commits into from
Mar 8, 2022

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 2, 2022

The patch is taken from this PR yaml/libyaml#244

This is in support of ros2/ros2#1150

The externalproject_add( changes are from ignition_math6_vendor.

@sloretz sloretz requested a review from clalancette March 2, 2022 01:19
@sloretz sloretz self-assigned this Mar 2, 2022
@sloretz
Copy link
Contributor Author

sloretz commented Mar 2, 2022

CI (build: --packages-above-and-dependencies libyaml_vendor test: --packages-select libyaml_vendor)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left one thing that I think should be changed, but this otherwise looks good to me.

URL_MD5 2464078985a73f9d298689d36061143f
TIMEOUT 60
GIT_REPOSITORY https://github.com/yaml/libyaml.git
GIT_TAG 2c891fc7a770e8ba2fec34fc6b545c672beb37e6 # 0.2.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll point out that you can use an actual tag here (like 0.2.5), which I think would be preferable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that's preferable. Currently a URL to a zip file and an MD5 sum are used. The MD5 sum makes sure the archive contains what we expect it to (limited by the ease of which it is to make an MD5 collision these days). If GIT_TAG only says the human readable tag name, then a change to the tag upstream could break the build, or worse be a security issue. Using the sha hash solves that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We discussed this elsewhere, and we are going to switch to git hashes everywhere. So with that, I'll go ahead and approve.

Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with green CI.

@sloretz
Copy link
Contributor Author

sloretz commented Mar 8, 2022

CI (build: --packages-above-and-dependencies libyaml_vendor test: --packages-select libyaml_vendor)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@sloretz sloretz merged commit 46065b1 into master Mar 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the sloretz__libyaml_vendor__include_project_name branch March 8, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants