Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] On new item, category dropdown disappears after error #4674

Open
2 tasks
cielf opened this issue Sep 29, 2024 · 1 comment
Open
2 tasks

[BUG] On new item, category dropdown disappears after error #4674

cielf opened this issue Sep 29, 2024 · 1 comment

Comments

@cielf
Copy link
Collaborator

cielf commented Sep 29, 2024

Summary

If you have an error on new item, the category list for selection disappears. It shouldn't.

Details

Recreation

login as [email protected]
Select Inventory, then Items & Inventory, then Items, then New Item
Click in the "Category" field. You will see a list of categories to choose from
Click Save
Click in the "Category" field. You no longer see a list of categories to choose from.

Hint

It's probably re-rendering without resetting up the category stuff.

Required change

The ability to select "Category" should still be available after having an error on this screen.

Criteria for completion

  • Behaviour as described above
  • tests to confirm the behaviour.

Noted by Gabe Torres, June 4 2024
"Thanks for posting, Daniela. It reminded me of something I noticed that also concerns forms. I thought it could have been my branch, but I tried it on main, and the issue persisted.
Recreating:
When logged in as a bank, navigate to http://localhost:3000/items/new
Submit a blank form.
Bug: The drop-down menu for category no longer functions and changes into some kind of numeric input that can be decreased or increased.
I’m not sure if this is a known issue or not, but I thought I’d share."

@bdeanhardt
Copy link

I tackled this one! Here's my PR #4703

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants