Superadmin Partners View (4682) & Category Dropdown Error (4674)

[bdeanhardt]

Resolves #4682 and #4674

Description

The super admin partners view is now in alphabetical order.
If you have an error on new item, the category list for selection will not disappear anymore.

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I reopened the super admin page after implementing my changes and the partners are now in alphabetical order.
I tried to reproduce the bug after implement my bug fix and I was unable to do so (categories will show up now despite an error).
Everything else still works as expected.

Screenshots

[cielf]

Hey @bdeanhardt -- Thank you! -- we'll take a look. One thing for future -- we usually put a PR for each issue we work on -- it's easier for the testers.

[cielf]

Also for future -- it's a better practice to make a branch, rather than making the changes in your main.

[cielf]

@bdeanhardt Could you make the order "human alphabetical" -- i.e. case insensitive, aka lower case alphabetical?, rather than "computer alphabetical", which orders all the lowercase after all the upper case, please?

(We're in the process of making the order of all the other alphabetical lists case-insensitive)

Thanks,

[cielf]

Hi @bdeanhardt
Welcome aboard! Thanks for your work on this!

The item fix works very well!

For the partner page, I'm afraid we had a slight misunderstanding on what we mean by alphabetical -- we want alphabetical the way English-speaking humans do it -- i.e. both 'A' and 'a' are treated the same.

We'll also need automated tests for both of these. That's what we mean when we need tests.

Please see the other procedural comments I've made, above, for future pull requests.