Release v0.6 #148
Release v0.6 #148
Conversation
jiangliu
requested review from
andreeaflorescu,
sameo,
sboeuf,
bonzini,
alexandruag and
serban300
and removed request for
bonzini and
alexandruag
|
@jiangliu can we push this a bit until we fix this comment: #125 (comment) @lauralt wants to submit a PR with it. |
sure, then I will try to create a patch for #149 |
|
I wonder if it's a good idea to break the exported types due to the dirty bitmap implementation. Perhaps export the new version from some sub-package, and leave those exported directly from |
I have give a try, but it always breaks existing users of GuestMemoryRegion. For example, I have tried to rename "GuestMemoryRegion" to "GuestMemoryRegionImpl", and defines Then existing users need to "use GuestMemoryRegionImpl" too, which still breaks:( |
|
I have tried several times to avoid breaking compatibility but failed:( |
|
We don't really give any guarantees related to the interface until we reach 1.0.0. I think we were also considering some other interface simplifications (#141), and I would be more inclined to first agree on those, implement them, and only then release 1.0.0. For this one, I would be fine with 0.6.0 even if we break the interface. |
jiangliu
force-pushed
the
v0.6
branch
3 times, most recently
from
668a947
to
3f961fc
Compare
There's a race window in observe_mutate() and we have observed it breaking the coverage test several times. So fix it by using Barrier. Signed-off-by: Liu Jiang <[email protected]>
jiangliu
force-pushed
the
v0.6
branch
2 times, most recently
from
a294dc6
to
41f24a1
Compare
src/volatile_memory.rs
Outdated
| @@ -1574,6 +1576,7 @@ mod tests { | |||
| // somehow and this helps to ensure the sleep actually happens before the store rather then | |||
There was a problem hiding this comment.
I would update the comments, so they do not mention about sleep anymore.
Release vm-memory v0.6, with latest dirty track bitmap implementation. Signed-off-by: Liu Jiang <[email protected]>
Release vm-memory v0.6, with latest dirty track bitmap implementation.