Relax BaseFloat bounds #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the trait more flexible. This contributes to rustgd#496.
kvark
approved these changes
May 22, 2020
There was a problem hiding this comment.
Looks good to me, thank you!
I'd love to get a second opinion on this before we proceed.
@brendanzab are you available to look at this?
|
Looks good to me! |
brendanzab
reviewed
May 23, 2020
| // Self: approx::AbsDiffEq<Epsilon = <Self as VectorSpace>::Scalar>, | ||
| // Self: approx::RelativeEq<Epsilon = <Self as VectorSpace>::Scalar>, | ||
| Self: approx::UlpsEq<Epsilon = <Self as VectorSpace>::Scalar>, | ||
| Self: MetricSpace<Metric = <Self as VectorSpace>::Scalar> |
There was a problem hiding this comment.
This looks so much nicer!
brendanzab
reviewed
May 23, 2020
| { | ||
| /// Vector dot (or inner) product. | ||
| fn dot(self, other: Self) -> Self::Scalar; | ||
|
|
||
| /// Returns `true` if the vector is perpendicular (at right angles) to the | ||
| /// other vector. | ||
| fn is_perpendicular(self, other: Self) -> bool { | ||
| fn is_perpendicular(self, other: Self) -> bool where Self::Scalar: approx::UlpsEq { |
brendanzab
approved these changes
May 23, 2020
|
Thank you for reviewing, @brendanzab ! |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a step towards finer grained trait bounds (#496)
Here I just relaxed the
BaseFloattrait bounds intonum_traits::FloatonInnerSpace,MetricSpaceandis_finite, and added the required bounds fromapproxto the functions that need it.This is helpful because it allows the use of common functions like
magnitudewithout having to implement theapproxtraits on the number type.