Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use php7.4 as minimum #1502

Merged
merged 3 commits into from
Nov 15, 2023
Merged

feat: use php7.4 as minimum #1502

merged 3 commits into from
Nov 15, 2023

Conversation

DeepDiver1975
Copy link
Member

refs #1415

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fb8b91) 97.32% compared to head (9296cf2) 97.22%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1502      +/-   ##
============================================
- Coverage     97.32%   97.22%   -0.11%     
+ Complexity     2833     2831       -2     
============================================
  Files           175      175              
  Lines          9425     9010     -415     
============================================
- Hits           9173     8760     -413     
+ Misses          252      250       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@phil-davis
Copy link
Contributor

@DeepDiver1975 there were 1807 unit tests running - for exampe https://github.com/sabre-io/dav/actions/runs/6862503131/job/18660341581
But only 887 unit tests have run in gthis PR: https://github.com/sabre-io/dav/actions/runs/6856309480/job/18643234604?pr=1502

Maybe renaming various test file to TestAbstract.php has caused that?

@DeepDiver1975
Copy link
Member Author

I will look into this.

@DeepDiver1975
Copy link
Member Author

@phil-davis we have now 1640 tests. Previously test within sabre/http were executed as well - but they no longer exist in the composer package. This is fine form my pov as it is no the job of sabre/dav to run sabre/http tests

@phil-davis
Copy link
Contributor

Previously test within sabre/http were executed as well
'
I had wondered why that was done, but without knowing the history I didn't like to stop running those sabre/http tests.

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@phil-davis
Copy link
Contributor

I will merge and we can progress from here towards a major version with type declarations etc.

@phil-davis phil-davis merged commit e77f38b into master Nov 15, 2023
7 of 8 checks passed
@phil-davis phil-davis deleted the feat/php7.4-min branch November 15, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants