-
Notifications
You must be signed in to change notification settings - Fork 125
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(VAlarm) Alarm related to DTSTART of VTODO
Following RFC 5545 the start of a VTODO is DTSTART not DUE Fixing the tests in consequence
- Loading branch information
1 parent
ad1a838
commit d734e21
Showing
2 changed files
with
15 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,6 +123,19 @@ public function timeRangeTestData(): array | |
$tests[] = [$valarm7, new \DateTime('2012-02-25 01:00:00'), new \DateTime('2012-03-05 01:00:00'), true]; | ||
$tests[] = [$valarm7, new \DateTime('2012-03-25 01:00:00'), new \DateTime('2012-04-05 01:00:00'), false]; | ||
|
||
// Relation to start time of todo | ||
$valarm8 = $calendar->createComponent('VALARM'); | ||
$valarm8->TRIGGER = '-P1D'; | ||
$valarm8->TRIGGER['VALUE'] = 'DURATION'; | ||
|
||
$vtodo8 = $calendar->createComponent('VTODO'); | ||
$vtodo8->DTSTART = '20120301T130000Z'; | ||
$vtodo8->DUE = '20120401T130000Z'; | ||
$vtodo8->add($valarm8); | ||
|
||
$tests[] = [$valarm8, new \DateTime('2012-02-25 01:00:00'), new \DateTime('2012-03-05 01:00:00'), true]; | ||
$tests[] = [$valarm8, new \DateTime('2012-03-25 01:00:00'), new \DateTime('2012-04-05 01:00:00'), false]; | ||
|
||
return $tests; | ||
} | ||
|
||
|
@@ -151,7 +164,7 @@ public function testInTimeRangeBuggy(): void | |
DTSTAMP:20121003T064931Z | ||
UID:[email protected] | ||
STATUS:NEEDS-ACTION | ||
DUE:20121005T000000Z | ||
DTSTART:20121005T000000Z | ||
SUMMARY:Task 1 | ||
CATEGORIES:AlarmCategory | ||
BEGIN:VALARM | ||
|