Skip to content

Commit

Permalink
feat(helm): Uplift to Helm v3, various requests, tag latest image (#249)
Browse files Browse the repository at this point in the history
* feat(container): Push latest tag during release

* feat(helm): Upgrade from Helm v2 to Helm v3 spec

* feat(helm): Update Container Registry to GitHub

New images are only pushed to GHCR.

* feat(helm): Enable use of emptyDir volumes for testing

When the PVC is enabled, a PV will be created and mounted to the pod
instead of the emptyDir.

* feat(helm): Enable use of imagePullSecrets

For pulling images from a private registry.
  • Loading branch information
karlskewes authored Jan 28, 2023
1 parent 2bfe114 commit 1ac931c
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 3 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
images: ghcr.io/${{ github.repository }}
# generate Docker tags based on the following events/attributes
tags: |
type=raw,value=latest,enable=${{ github.ref == format('refs/heads/{0}', 'master') }}
type=ref,event=branch
type=ref,event=pr
type=semver,pattern={{version}}
Expand Down
4 changes: 2 additions & 2 deletions helm/sloop/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v1
apiVersion: v2
appVersion: "1.0"
description: Sloop is a kubernetes history visualization tool.
name: sloop
version: 0.1.0
version: 0.2.0
icon: https://raw.githubusercontent.com/salesforce/sloop/master/other/sloop_logo_color.png
6 changes: 6 additions & 0 deletions helm/sloop/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ spec:
name: sloop-data
- mountPath: /sloopconfig/
name: sloopconfig
{{- with .Values.image.pullSecrets }}
imagePullSecrets:
{{- toYaml . | nindent 8 }}
{{- end }}
volumes:
- emptyDir:
sizeLimit: {{ .Values.persistentVolume.sizeLimit }}
Expand All @@ -74,6 +78,7 @@ spec:
name: {{ .Values.name }}
name: sloopconfig
serviceAccountName: {{ .Values.serviceAccountName }}
{{- if .Values.persistentVolume.enabled }}
volumeClaimTemplates:
- metadata:
name: sloop-data
Expand All @@ -86,3 +91,4 @@ spec:
resources:
requests:
storage: {{ .Values.persistentVolume.size }}
{{- end }}
6 changes: 5 additions & 1 deletion helm/sloop/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,13 @@ name: sloop
replicas: 1
image:
tag: latest
repository: sloopimage/sloop
repository: ghcr.io/salesforce/sloop
pullPolicy: IfNotPresent
# pullSecrets:
# - name: example-secret
persistentVolume:
# If false then an emptyDir will be used.
enabled: true
## If defined it will specify the storageClass for the statefulSet
## If undefined it will use the cluster default (typically gp2 on AWS, standard on GKE)
# storageClass:
Expand Down

0 comments on commit 1ac931c

Please sign in to comment.