Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix date exclusion #57

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix date exclusion #57

wants to merge 2 commits into from

Conversation

stefanv
Copy link
Member

@stefanv stefanv commented Jun 8, 2023

This is an attempt at resolving #51 and #54.

  1. except_on and also_on failed to work on calendars without timezones. Now, calendars default to UTC if no timezone is specified.
  2. According to Exceptions must include time #51, adding a timestamp to except_on should make it work. This PR does that, but it doesn't work yet.

/cc @itrich

@jarrodmillman jarrodmillman added this to the 0.3 milestone Jun 8, 2023
@jarrodmillman jarrodmillman added the type: Bug fix Something isn't working label Jul 2, 2023
@stefanv stefanv marked this pull request as draft September 15, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarrodmillman jarrodmillman jarrodmillman approved these changes

Assignees
No one assigned
Labels
type: Bug fix Something isn't working
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@stefanv @jarrodmillman