Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making the trace component of SparseKernelNormalizer more memory-frie… #219

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rosecers
Copy link
Collaborator

@rosecers rosecers commented Nov 17, 2023

…ndly

Using the equality of traces under cyclic products, I've modified the sparse kernel
normalizer to be less memory-hungry. Had a few issues using this and having RAM crash

Contributor (creator of PR) checklist

  • Tests updated (for new features and bugfixes)?
  • Documentation updated (for new features)?
  • Issue referenced (for PRs that solve an issue)?

For Reviewer

  • CHANGELOG updated if important change?

📚 Documentation preview 📚: https://scikit-matter--219.org.readthedocs.build/en/219/

src/skmatter/preprocessing/_data.py Outdated Show resolved Hide resolved
@PicoCentauri
Copy link
Collaborator

What is the status here?

Seems like we have to fix some assertions in the test_sparse_kernel_centerer.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants