Add MyPy type checking #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, it looks like excludes have to be duplicated. Not sure why.
|
Hah, I introduced an emoji and pdflatex does not like it. xelatex is probably more future proof, but simplest fix here is to remove the emoji. |
|
Ready to go, I think! |
bsipocz
approved these changes
Sep 20, 2024
| - pandas-stubs | ||
| - types-pillow | ||
| - matplotlib | ||
| exclude: | |
There was a problem hiding this comment.
I wonder if pre-commit could reuse the config and thus this exclude list from pyproject.toml?
There was a problem hiding this comment.
That's the part I could not get to work :/ I don't know why it doesn't!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.