New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: one way to remove many arguments with HashMap #1122

Open

ludete wants to merge 2 commits into scroll-tech:develop from ludete:yyx

ludete commented Feb 26, 2024 •

edited

Loading

Description

Remove many args in function with HashMap and add trait to enum

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Contents

Use HashMap to remove many tables args in function
Add AsRefStr of trait to enum(Table, CellType)
Use the str expression of enum as key to the HashMap


          refactor: one way to remove many arguments in function with HashMap

745932b

github-actions bot added the crate-zkevm-circuits label


          feat: remove property(too_many_arguments) of clippy

e9ee050

ludete changed the title ~~refactor: one way to remove many arguments in function with HashMap~~ Fix: one way to remove many arguments with HashMap

ludete changed the title ~~Fix: one way to remove many arguments with HashMap~~ Refactor: one way to remove many arguments with HashMap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crate-zkevm-circuits