Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove is-plain-obj #1139

Closed

Conversation

Jayllyz
Copy link

@Jayllyz Jayllyz commented Aug 6, 2024

Changes

Removed is-plain-obj in favor of a oneline function.

Context

As part of the ongoing ecosystem cleanup, we are migrating various projects to use lighter/faster package or alternatives.

image

https://github.com/TheDevMinerTV/package-size-calculator

How I've tested my work

npm run test 4982 tests passed

@sindresorhus
Copy link
Owner

Not sure I see the point of this. This will have very little impact on the cleanup effort. The real problems in the ecosystem is that certain packages support too low Node.js versions and include polyfills for everything. This also feels like a slippery slope to inline even more, which means code gets duplicated, and potential bug fixes or improvements don't get included.

The proper fix would be to convince TC39 to add a method like this to JS: https://es.discourse.group

@ehmicky
Copy link
Collaborator

ehmicky commented Aug 6, 2024

100% agree with @sindresorhus. 👍

@Jayllyz Jayllyz deleted the refactor/remove-is-plain-obj branch August 7, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants