main: use authoritive backends when getting number of contacts

sni · Jul 10, 2023 · 6c65ee7 · 6c65ee7
1 parent 005138d
commit 6c65ee7
Show file tree

Hide file tree

Showing 2 changed files with 49 additions and 0 deletions.
diff --git a/lib/Thruk/Action/AddDefaults.pm b/lib/Thruk/Action/AddDefaults.pm
@@ -1180,6 +1180,36 @@ sub set_enabled_backends {
     return($disabled_backends);
 }
 
+########################################
+
+=head2 has_backends_set
+
+  has_backends_set($c)
+
+    returns 1 if user has set custom backends
+
+=cut
+sub has_backends_set {
+    my($c) = @_;
+    my $num_backends = scalar @{$c->db->get_peers()};
+    my $cookie_src   = $c->stash->{'backend_cookie_src'} // 'thruk_backends';
+    if($num_backends <= 1) {
+        return;
+    }
+    if(defined $c->cookies($cookie_src)) {
+        return(1);
+    }
+    my $backend  = $c->req->parameters->{'backend'} || $c->req->parameters->{'backends'};
+    if(defined $backend) {
+        return(1);
+    }
+    if(defined $ENV{'THRUK_BACKENDS'}) {
+        return(1);
+    }
+
+    return;
+}
+
 ########################################
 sub _set_disabled_by_section {
     my($c, $backend, $disabled_backends) = @_;

diff --git a/lib/Thruk/Controller/main.pm b/lib/Thruk/Controller/main.pm
@@ -447,17 +447,36 @@ sub _get_contacts {
     my($c) = @_;
     $c->stats->profile(begin => "_get_contacts");
 
+    my $backends = Thruk::Action::AddDefaults::has_backends_set($c) ? undef : $c->db->authoritive_peer_keys();
+
     my $data = $c->db->caching_query(
         $c->config->{'var_path'}.'/caching_query.contact_names.cache',
         'get_contacts',
         {
             columns    => [qw/name/],
             debug_hint => 'total contacts',
+            backends   => $backends,
         },
         sub { return $_[0]->{'name'}; },
         1,
     );
 
+    # take shortcut if its only one backend
+    my $key;
+    if($backends && scalar @{$backends} == 1) {
+        $key = (keys %{$data})[0];
+    }
+    elsif(scalar keys %{$data} == 1) {
+        $key = (keys %{$data})[0];
+    }
+
+    if($key) {
+        my $num = scalar @{$data->{$key}};
+
+        $c->stats->profile(end => "_get_contacts");
+        return($num);
+    }
+
     my $uniq = {};
     for my $peer_key (sort keys %{$data}) {
         for my $name (@{$data->{$peer_key}}) {