feat(tenant-management):integrate auth0 #48
Conversation
add keycloak idp configuration BREAKING CHANGE: yes 43
Surbhi-sharma1
force-pushed
the
idp-1
branch
from
4ae038f
to
ad52c16
Compare
Surbhi-sharma1
force-pushed
the
idp-1
branch
from
ad52c16
to
e5730d1
Compare
Surbhi-sharma1
force-pushed
the
idp-1
branch
from
26c74b7
to
087a642
Compare
There was a problem hiding this comment.
add the trigger to update the modified_on time whenever there is an update
| jsonSchema: getJsonSchema(Object), | ||
| }) | ||
| plan: AnyObject; | ||
|
|
There was a problem hiding this comment.
plans will be separate not a part of tenant
| @property({ | ||
| type: 'object', | ||
| required: true, | ||
| name: 'config_value', | ||
| }) | ||
| configValue: ConfigValue; | ||
|
|
There was a problem hiding this comment.
why is the configValue type defined like this
it not specific to just auth0 and organizations
its a generic table that can be used for anything in future
its just a json value https://github.com/sourcefuse/loopback4-microservice-catalog/blob/master/services/authentication-service/src/models/tenant-config.model.ts
| KEYCLOAK = 'keycloak', | ||
| } | ||
|
|
||
| export type ConfigureIdpFunc<T> = (payload: IdpDetails) => Promise<T>; |
| const tenantConfig = await this.tenantConfigRepository.findOne({ | ||
| where: {tenantId: tenant.id}, | ||
| }); | ||
| if (!tenantConfig) { | ||
| throw new HttpErrors.NotFound( | ||
| `Tenant configuration not found for tenant: ${tenant.id}`, | ||
| ); | ||
| } | ||
| const configValue: ConfigValue = tenantConfig.configValue; | ||
| if (!configValue) { | ||
| throw new HttpErrors.NotFound( | ||
| `Tenant configuration not found for tenant: ${tenant.id}`, | ||
| ); | ||
| } | ||
|
|
||
| const organizationData: OrganizationData = { |
There was a problem hiding this comment.
tenant_config depends on two things
tenant_id and config_key
please take key also into account as I can store diff types of config for a tenant
There was a problem hiding this comment.
why userdata and organizationdata types defined
arent these defined in the auth0 management package
|
Also is this #38 PR included in this new PR ?? |
Surbhi-sharma1
force-pushed
the
idp-1
branch
from
087a642
to
2a217a8
Compare
|
|
#51 |
Description
integrate auth0 in tenant management service
Fixes #47
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: