Gh 47 #53
Open
Gh 47 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… service add billing functionality to subscription service BREAKING CHANGE: yes gh-34
update billing package tar BREAKING CHANGE: yes gh-34
update package lock BREAKING CHANGE: yes gh-34
update tar file of billing package gh-34
add saastenantrepo for webhook handler gh-34
configure idp for user BREAKING CHANGE: yes 43
sdhgs BREAKING CHANGE: yes 43
integrate auth0 GH-47
integrate auth0 GH-47
add common response type for all provider 47
add invoice id in subscription dto 47
Tyagi-Sunny
commented
Oct 7, 2024
Tyagi-Sunny
commented
Oct 7, 2024
| description: 'Tenat object', | ||
| jsonSchema: getJsonSchema(Object), | ||
| }) | ||
| tenant: AnyObject; |
There was a problem hiding this comment.
why are we giving tenant as AnyObject
Tyagi-Sunny
commented
Oct 7, 2024
| @model({ | ||
| description: 'model describing payload used to create a lead', | ||
| }) | ||
| export class TenantDto extends Tenant { |
There was a problem hiding this comment.
made changes to TenantDto and set this as type of tenant in IdpDetailsDto
Tyagi-Sunny
commented
Oct 7, 2024
| @@ -0,0 +1,4 @@ | |||
| export type Auth0Response = { | |||
There was a problem hiding this comment.
as we are using a commong resp IdpResp={authId:string}, we can remove this Auth)response
Tyagi-Sunny
commented
Oct 7, 2024
| WebhookController, | ||
| IdpController, | ||
| TenantConfigController, | ||
| TenantConfigTenantController, |
There was a problem hiding this comment.
remove tenantConfigController and tenantconfigtenat controller from here. only idp controller should be here
…rvice remove idp controller from tenantMnagement service 47
add another interceptor for callback methods GH-47
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: