ICS: support different presentation (file, HTML) #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
atymic
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context and Purposes
Idea: a lot of people asking to support output of the ICS to a file.
There were few PRs, all of them used
$optionsargument that already used for optional ICS components and properties. Mixing them with presentation logic (that is not related to ICS format at all) is a bad practice.By this PR I tried to implement the same functionality but keep additional components and presentation logic separated.
This should also unblock other PRs to add more optional ICS components and properties, like this one: https://github.com/spatie/calendar-links/pull/178/files