added slakh processing, tests, and test data, tox passing. #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave more stable dataset division.
…d data and tests + uploaded download.py for maestro, added test data for maestro, updated Manifest for wav and midi files in test
… repo. Also removed metadata csv file as it wasn't being used in the code.
drubinstein
reviewed
Jul 30, 2024
There was a problem hiding this comment.
(1) I'm not going to merge this many .mid files in. If you could programatically generate them, I'd appreciate it.
(2) Looks like this repo includes maestro changes. It shouldnt need them
(3) Can you update the README either in this or in another PR to include that sox/ffmpeg are now required for data installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to review: