-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Configuration for Kotlin's All-Open Plugin for JPA Entities #1576
Open
YangSiJun528
wants to merge
20
commits into
spring-io:main
Choose a base branch
from
YangSiJun528:kotlin-all-open-for-jpa
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add Configuration for Kotlin's All-Open Plugin for JPA Entities #1576
YangSiJun528
wants to merge
20
commits into
spring-io:main
from
YangSiJun528:kotlin-all-open-for-jpa
+141
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rename methods - Simplify allOpen.invoke
- Add Configure kotlin + allOpen
- Add author tag of JavaDoc
spring-projects-issues
added
the
status: waiting-for-triage
An issue we've not yet triaged
label
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
KotlinJpaGradleBuildCustomizer
class is responsible for configuring eitherjavax
orjakarta
dependencies. I believe a cleaner approach would be to split this functionality into two separate classes:KotlinJavaxJpaGradleBuildCustomizer
KotlinJakartaJpaGradleBuildCustomizer
I'm unsure whether these new classes should inherit from
KotlinJpaGradleBuildCustomizer
or be designed as independent classes that implementBuildCustomizer
. (similar toKotlinJpaMavenBuildCustomizer
)I would appreciate feedback on this approach.
Fixes gh-1572