This repository has been archived by the owner on Oct 19, 2021. It is now read-only.
Detect build when Hearthstone is launched #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is an infrequent operation. Can you specify why these rare multiple allocations are a problem for you? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
We only need to detect build on hearthstone start ( since it won't change until restart )
DetecBuid() is invoked multiple of times and via HearthstoneCardDB::CardsJsonLocalPath() ( among others) - on mac it opens a file and reads it; if it the same on windows as its done in wine there are also multiple allocations to get file version.