Fix infinite loop location api (#787)

stripe · Aug 15, 2024 · 6e63892 · 6e63892
1 parent c98244a
commit 6e63892
Showing 1 changed file with 8 additions and 5 deletions.
diff --git a/dev-app/src/screens/LocationListScreen.tsx b/dev-app/src/screens/LocationListScreen.tsx
@@ -24,7 +24,7 @@ export default function LocationListScreen() {
   const { params } = useRoute<RouteProp<RouteParamList, 'LocationList'>>();
 
   const { getLocations, loading } = useStripeTerminal();
-  const [list, setList] = useState<Location[]>([]);
+  const [list, setList] = useState<Location[]>(cachedLocations);
   const dummyLocations: Location[] = [
     { id: 'ABCD', displayName: 'Bad Location', livemode: false },
     {
@@ -34,18 +34,21 @@ export default function LocationListScreen() {
     },
   ];
 
+  useEffect(() => {
+    if (list != null && list.length != 0) {
+      setCachedLocations(list);
+    }
+  }, [list, setCachedLocations]);
+
   useEffect(() => {
     async function init() {
       const { locations } = await getLocations({ limit: 20 });
       if (locations) {
         setList(locations);
-        setCachedLocations(locations);
-      } else {
-        setList(cachedLocations);
       }
     }
     init();
-  }, [getLocations, setCachedLocations, cachedLocations]);
+  }, [getLocations]);
 
   const renderItem = (item: Location) => (
     <ListItem