Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite statement splitter #138

Draft
wants to merge 19 commits into
base: main
Choose a base branch
from
Draft

fix: rewrite statement splitter #138

wants to merge 19 commits into from

Conversation

psteinroe
Copy link
Collaborator

@psteinroe psteinroe commented Aug 9, 2024

this pr rewrites the statement splitter so that it passes through all postgres regression tests.

closes #135

todos:

  • introduce Repeated syntax definition to parse CTEs and UNION etc better
  • add support for multiline comments in the tests (and check if the parser properly parses them too)
  • make the tracker return false by default if a position reached the end of the definition and by that, require an AnyTokens to be the last in every definition. this will make the TABLE my_table syntax work much better
  • dont skip any regression tests anymore

@psteinroe psteinroe changed the title fix: rewrite statement splitter wip fix: rewrite statement splitter Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Statement Splitter
1 participant